Skip to content

build: support armv81 arch in Makefile#776

Merged
imguoguo merged 1 commit intosipeed:mainfrom
ztechenbo:main
Feb 26, 2026
Merged

build: support armv81 arch in Makefile#776
imguoguo merged 1 commit intosipeed:mainfrom
ztechenbo:main

Conversation

@ztechenbo
Copy link
Contributor

@ztechenbo ztechenbo commented Feb 25, 2026

build: support armv81 arch detection in Makefile

📝 Description

This PR updates the Makefile Linux architecture detection to recognize armv81 and map it to arm64, so builds work correctly on systems reporting uname -m = armv81.

🗣️ Type of Change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 📖 Documentation update
  • ⚡ Code refactoring (no functional changes, no api changes)

🤖 AI Code Generation

  • 🤖 Fully AI-generated (100% AI, 0% Human)
  • 🛠️ Mostly AI-generated (AI draft, Human verified/modified)
  • 👨‍💻 Mostly Human-written (Human lead, AI assisted or none)

🔗 Related Issue

N/A

📚 Technical Context (Skip for Docs)

  • Reference URL: N/A
  • Reasoning: Some environments report uname -m as armv81. Without this mapping, the build target arch may be mis-detected, leading to incorrect output naming/packaging. This change treats armv81 as arm64.

🧪 Test Environment

  • Hardware: N/A
  • OS: Linux
  • Model/Provider: N/A
  • Channels: N/A

📸 Evidence (Optional)

Click to view Logs/Screenshots

Built successfully after updating arch detection for armv81.

☑️ Checklist

  • My code/docs follow the style of this project.
  • I have performed a self-review of my own changes.
  • I have updated the documentation accordingly.

nikolasdehor
nikolasdehor approved these changes Feb 25, 2026
View reviewed changes
Copy link

@nikolasdehor nikolasdehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward 2-line Makefile change to map armv81 to arm64. Follows the existing pattern for aarch64. LGTM.

One thought: there are also armv8l variants (lowercase L) reported by some kernels (e.g., 32-bit userspace on 64-bit ARM). If the goal is broad ARMv8 coverage, that might be worth adding too, but that can be a separate PR.

@xiaket xiaket added type: enhancement New feature or request domain: ci labels Feb 26, 2026
@xiaket xiaket requested a review from imguoguo February 26, 2026 09:36
@imguoguo imguoguo merged commit cb3191c into sipeed:main Feb 26, 2026
2 checks passed
@imguoguo
Copy link
Member

imguoguo commented Feb 26, 2026

LGTM

@Orgmar
Copy link

Orgmar commented Feb 27, 2026

@ztechenbo Good catch on the armv81 detection. Systems reporting that uname string would have gotten the wrong build target without this mapping. Nice and minimal fix.

We have a PicoClaw Dev Group on Discord for contributors to chat and collaborate. If you're interested, send an email to support@sipeed.com with the subject [Join PicoClaw Dev Group] ztechenbo and we'll send the invite link your way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imguoguo imguoguo imguoguo approved these changes

+1 more reviewer

@nikolasdehor nikolasdehor nikolasdehor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

domain: ci type: enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ztechenbo @imguoguo @Orgmar @nikolasdehor @xiaket